Allow the installation on PHP 8

1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.

MIT License

630 stars 118 forks source link

Allow the installation on PHP 8 #220

Closed derrabus closed 3 years ago

derrabus commented 3 years ago

Hello! 👋🏻

I'd like to use your awesome bundle on PHP 8, so I'd like to ask if we could allow composer to install it.

bytehead commented 3 years ago

Hey Alexander

Yes, for sure. Thanks for your contribution!

bytehead commented 3 years ago

Don't know if tests will run through, but let's see :)

derrabus commented 3 years ago

The tests pass, but with deprecation warnings because of the deprecated expectedException annotations.

bytehead commented 3 years ago

Is it intended to run on Symfony 3.4 with PHP 8? Will Symfony 3.4 support PHP 8? https://travis-ci.org/github/1up-lab/OneupFlysystemBundle/jobs/748102802

derrabus commented 3 years ago

We have patched Symfony 3.4 for PHP 8.0, yes. But because the maintenance of the 3.4 branch has ended, I would consider the PHP 8 support as experimental. KernelTestCase of the 3.4 branch will probably only work if we use PHPUnit bridge to patch PHPUnit's return type declarations.

I can do that for you, but it's maybe enough to just skip that combination.

bytehead commented 3 years ago

I'll skip it :-)