search

1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 118 forks source link

Support for async-aws/flysystem-s3 1.0 #223

Closed derrabus closed 3 years ago

derrabus commented 3 years ago

When bumping to 1.0, the Async AWS folks decided to rename their adapter class. This PR makes the necessary adjustments.

I don't know how the BC policies of this project are. Should I build some kind of compatibility layer to support both, 0.4 and 1.0 of that library at the same time? Or is this change acceptable as it is?

derrabus commented 3 years ago

Friendly ping to @Nyholm who has built the Async AWS integration in #209.

Nyholm commented 3 years ago

Thank you for the ping.

The conflict section in the composer.json will make this PR backwards compatible.

Well done

bytehead commented 3 years ago

Thank you @derrabus and @Nyholm!

Nyholm commented 3 years ago

Thank you for merging

Nyholm commented 3 years ago

Note that for Flysystem v2 there is official support: https://packagist.org/packages/league/flysystem-async-aws-s3

bytehead commented 3 years ago

I've already started a branch for 4.x to support Flysystem v2 :)

bytehead commented 3 years ago

@derrabus 3.7.0 is available!