search

1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 118 forks source link

Use same name for memory adapter #229

Closed fullbl closed 3 years ago

fullbl commented 3 years ago

Hi, I got an error with the 4.0 version: 1) Vich\UploaderBundle\Tests\VichUploaderBundleTest::testFlysystemOneUpKernel Symfony\Component\DependencyInjection\Exception\RuntimeException: Service "oneup_flysystem.memory_adapter_adapter": Parent definition "oneup_flysystem.adapter.memory" does not exist.

I solved using the old name "memory", the name was "in_memory" in configuration and "memory" in yaml. I thought that it could be better to use the same name as before.

Moreover, I added adapter creations to tests, it becomes red in master, green in my branch!

bytehead commented 3 years ago

Thank you! ❤️

bytehead commented 3 years ago

I've published 4.0.1. Thanks again!

fullbl commented 3 years ago

This was fast! Thanks to you!