1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 118 forks source link

Use the "mount" attribute as the mount identifier #239

Closed meyerbaptiste closed 2 years ago

meyerbaptiste commented 3 years ago

Given the following configuration:

oneup_flysystem:
    # ...
    filesystems:
        foo_fs:
            # ...
            mount: foo

The current behaviour uses the filesystem service identifier as mount identifier:

$container->get('oneup_flysystem.mount_manager')->write('oneup_flysystem.foo_fs_filesystem://bar/baz', 'qux');

But when I use the mount attribute I expect it to be my mount identifier:

$container->get('oneup_flysystem.mount_manager')->write('foo://bar/baz', 'qux');

And if the mount attribute is not specified, let's default to the filename key:

$container->get('oneup_flysystem.mount_manager')->write('foo_fs://bar/baz', 'qux');
stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bytehead commented 2 years ago

Thank you for the PR! Can you fix the issue mentioned by PHPStan?

bytehead commented 2 years ago

And if possible do a rebase against the main branch?

bytehead commented 2 years ago

Thank you! 🥳

bytehead commented 2 years ago

4.1.3 is released, thanks again!