search

1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 118 forks source link

Fix local adapter configuration to work with League\Flysystem #253

Closed saviks closed 2 years ago

saviks commented 2 years ago

Bug Report

Q A
BC Break yes
Version 4.1.4

Summary

Permission config parameters for local adapter are never used.

Code checks existence of visibilityConverter in configuration which is not allowed. Additionally used parameters for function fromArray are not valid.

dkorsak commented 2 years ago

+1

bytehead commented 2 years ago

Thank you @saviks for contribution. I'm not sure if it's a BC break, as it is buggy since day one then. Am I right?

saviks commented 2 years ago

@bytehead it has not worked ever since some major version upgrade when this configuration was not needed, so I am not sure is it considered BC.

bytehead commented 2 years ago

I'll fix it then in a patch 👍

bytehead commented 2 years ago

@saviks can you fix the code style issue mentioned by the CI?

bytehead commented 2 years ago

Thank you!

bytehead commented 2 years ago

4.2.1 is released. Thank you again! 🙏