1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 119 forks source link

Add support for sf ^6.0 #257

Closed odolbeau closed 2 years ago

odolbeau commented 2 years ago

This PR:

Last 2 points can be reverted if needed.

Fix #256

odolbeau commented 2 years ago

If (as I am), you're bored of approving workflows run, I just found this can be configured here as explained in the documentation! :partying_face:

elkuku commented 2 years ago

Please merge :wink:

ltlsquare commented 2 years ago

Looks good guys, is there anything else that needs to be done? can help out to get this over the line?

odolbeau commented 2 years ago

There is some permission errors with PHP 8 but I cannot reproduce the bug on my laptop. @meyerbaptiste, it looks like its linked to the visibility config you added in 4.2.0, could you please take a look? :pray:

meyerbaptiste commented 2 years ago

@odolbeau, I just sent you a PR!

odolbeau commented 2 years ago

@odolbeau, I just sent you a PR!

@meyerbaptiste do you have a link please? I don't know what you're talking about... :thinking:

bytehead commented 2 years ago

@odolbeau https://github.com/odolbeau/OneupFlysystemBundle/pull/1 🙃

odolbeau commented 2 years ago

Thanks! I didn't get notified, that's strange! Anyway, thanks a lot @meyerbaptiste, it looks like CI is happy! :ok_hand:

odolbeau commented 2 years ago

I did not removed support for sf 5.3 as this version is still maintained for now https://symfony.com/releases

bytehead commented 2 years ago

Thank you @odolbeau & @meyerbaptiste ❤️

bytehead commented 2 years ago

I've released 4.3.0