1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 119 forks source link

Config Adapter sftp load PhpseclibV2 no PhpseclibV3 #270

Closed pacofall closed 1 year ago

pacofall commented 1 year ago

Bug Report

Symfony 6 and league/flysystem-sftp-v3

Attempted to load class "SftpAdapter" from namespace "League\Flysystem\PhpseclibV2".

In adapter.xml still:

and class SftpFactory implements AdapterFactoryInterface use: use League\Flysystem\PhpseclibV2\SftpConnectionProvider; | Q | A |------------ | ------ | BC Break | yes | Version | x.y.z #### Summary #### How to reproduce
pacofall commented 1 year ago

Add adapter "sftpv3" in config will be welcome.

bytehead commented 1 year ago

We'll have to add a new adapter sftpv3 otherwise we're not backwards compatible anymore.

bytehead commented 1 year ago

Which PHP version are you using?

pacofall commented 1 year ago

Thanks for reply.. on PHP 8.1; which require League\Flysystem\PhpseclibV3......

bytehead commented 1 year ago

Ok πŸ‘ I'll prepare a release 4.6.0 which replaces PhpseclibV2 with PhpseclibV3 (PHP 7 support was dropped for 4.5.0 anyway).

bytehead commented 1 year ago

@pacofall any reason why are you not using league/flysystem-sftp as suggested by the bundle?

pacofall commented 1 year ago

It s solution we used currently according https://flysystem.thephpleague.com/docs/adapter/sftp-v3/.

We get issues by config.yaml way which use default config adapter.

doc config.yml

oneup_flysystem:
adapters:
        my_adapter:
            sftp:
                options:
                    host: 'ftp.domain.com'
                    username: 'foo'
                    root: '/upload'
24s-dcognata commented 1 year ago

βœ‹πŸ» @bytehead , any news for a fix ?

Your PR seem ready to be merged

bytehead commented 1 year ago

@24s-dcognata could you test PR #272 successfully?

24s-dcognata commented 1 year ago

Hi @bytehead, we'll try to test this PR on our app today or by next week.

bytehead commented 1 year ago

@24s-dcognata thanks πŸ™ let me know the outcome ☺️

24s-dcognata commented 1 year ago

Hi @bytehead

Sorry for the wait,

we tested your PR, everything works on our application. πŸŽ‰

bytehead commented 1 year ago

@24s-dcognata 4.6.0 is released.