search

1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 119 forks source link

Fix spelling of "defaultVisiblity" => "defaultVisibility" #299

Closed Chris53897 closed 5 months ago

Chris53897 commented 6 months ago

https://github.com/1up-lab/OneupFlysystemBundle/issues/255

I just come across this, as my IDE did notice.

Needs a closer look.

bytehead commented 5 months ago

I consider this as a bug - probably didn't work properly. Only if you misspelled it as well in your config. What do you think?

Chris53897 commented 5 months ago

In my eyes it is a bug fix and a BC Break. I guess People find out quickly after upgrading.Composer will clear cache and give a warning/error about wrong config.I think this can be part of a minor update, but with a good visible info, about this change.Am 11.03.2024 um 10:30 schrieb David Greminger @.***>: I consider this as a bug - probably didn't work properly. Only if you misspelled it as well in your config. What do you think?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were assigned.Message ID: @.***>

bytehead commented 5 months ago

I call it clearly a bug and it will be fixed in a bugfix release 👍

bytehead commented 5 months ago

Thank you ❤️