Symfony 5.3: RequestStack::getMasterRequest() is deprecated, use getMainRequest() instead

1up-lab / OneupUploaderBundle

This Symfony bundle provides a server implementation for handling single and multiple file uploads using either FineUploader, jQuery File Uploader, YUI3 Uploader, Uploadify, FancyUpload, MooUpload, Plupload or Dropzone. Features include chunked uploads, orphanages, Gaufrette and Flysystem support.

MIT License

603 stars 177 forks source link

Symfony 5.3: RequestStack::getMasterRequest() is deprecated, use getMainRequest() instead #407

Closed keksa closed 3 years ago

keksa commented 3 years ago

Hello, just reporting a deprecation notice, that bubbled up from our tests.

Since symfony/http-foundation 5.3: "Symfony\Component\HttpFoundation\RequestStack::getMasterRequest()" is deprecated, use "getMainRequest()" instead.

https://github.com/1up-lab/OneupUploaderBundle/blob/3d711a21d4a983443797b83bd763557067e72b85/src/Controller/AbstractController.php#L229

keksa commented 3 years ago

Found another one, sessions as a service are deprecated too: https://github.com/1up-lab/OneupUploaderBundle/blob/3d711a21d4a983443797b83bd763557067e72b85/src/Controller/AbstractController.php#L69

https://symfony.com/blog/new-in-symfony-5-3-session-service-deprecation

bytehead commented 3 years ago

Thank you!

bytehead commented 3 years ago

Closing in favor of #408