search

1up-lab / contao-ical-export

A contao module for downloading ical files generated from events. The output will follow RFC 2445 as best as possible.
MIT License
6 stars 2 forks source link

iCal Download does not work when URL contains Parameters #7

Closed Kahmoon closed 5 years ago

Kahmoon commented 5 years ago

The default detail link of the eventreader contains URL parameters. Then the download of the ical element does not work.

When you set "no parameters" in calendar module it works fine.

For listing module there is no such option...you have to clean up the link via regular expressions in template.

bytehead commented 5 years ago

I cannot reproduce this in the offical demo on my local machine. My eventreader module doesn't even have a setting "no parameters": bildschirmfoto 2019-02-08 um 19 00 01

Can you give some more information to reproduce the situation?

Kahmoon commented 5 years ago

This setting is in module calendar,not reader. See right bottom corner of the screenshot. And it seems to be an option from calendar_extend at the end.

Bildschirmfoto-2019-02-08-um-19-20-14

In Contao Demo (https://demo.contao.org/en/events.html?month=201905) the link to an event got no parameters at all....thats fine. Parameters seems to be set via calendar_extend

On listing templates you have to remove it via regexp

We can close this issue ;-). Sorry

bytehead commented 5 years ago

I'll check, maybe we can fix this anyway.

Kahmoon commented 5 years ago

The link in my listing & reader is like. myfolder/test-8-2-kopie.html?day=20190208&times=1549580400,1549666799

The downloadlink from your module becomes myfolder/test-8-2-kopie.html?day=20190208&times=1549580400,1549666799?ics

So we have two beginnings of parameter "?"

bytehead commented 5 years ago

Version 2.0.2 fixes this, thanks for reporting!