search

1up-lab / contao-mailchimp

Contao bundle for MailChimp subscribe/unsubscribe forms (using MailChimp API V3.0)
MIT License
7 stars 3 forks source link

Update to Haste 5 #45

Closed fritzmg closed 1 year ago

fritzmg commented 1 year ago

This unlocks Haste 5 and adjusts the code accordingly.

Note: I did not touch any of the other dependencies (Haste 5 requires at least PHP 8.1 and Contao 4.13)

bytehead commented 1 year ago

We will have to raise the requirements as well then, as this bundle is still compatible yet with Contao 4.9 and PHP 7.4. Is a compatiblity with Haste 4 and Haste 5 possible?

fritzmg commented 1 year ago

Is a compatiblity with Haste 4 and Haste 5 possible?

Technically yes with some class_exists and method_exists checks. Not sure if that's really worth it though? If you need Contao 4.9 and PHP 7.4, you can still install 4.7. And if you need compatibility with Haste 5 you can install 4.8 was my thinking.