search

1up-lab / contao-mailchimp

Contao bundle for MailChimp subscribe/unsubscribe forms (using MailChimp API V3.0)
MIT License
7 stars 3 forks source link

[RTM] Implement display_order handling for form fields #7

Closed bezin closed 7 years ago

bezin commented 7 years ago

Hi there,

as discussed in #6 , the implementation should respect the order of the form fields, that can be changed in the MailChimp interface. This PR takes care of this.

One known issue is, that since the email field itself is still not included in the API response, the chosen email field label in MailChimp is obviously not available in Contao. It still has to be changed through the language array, as it was prior to this PR.

Let me know what you all think :)

Cheers!

bytehead commented 7 years ago

Thank you for the PR! I'll review this asap.

bytehead commented 7 years ago

It would also be nice to have some kind of hint in the README.md, how to sort the fields:

You can not change order in Settings-->List fields and |MERGE| tags but you can in Signup forms --> General forms --> Signup form

The order you pick here (drag'n'drop) will also be visible in the |MERGE| tags view.

bezin commented 7 years ago

Thanks for your comments. I updated the PR accordingly.

bytehead commented 7 years ago

Thank you for the quick changes!

bytehead commented 7 years ago

I'll have to release a new major version (3.0.0) because of the not backward compatible changes.