1up-lab / contao-sibling-navigation

Provides a sibling navigation (Previous/Next) as a ContentElement or a Module for news, events and pages.
MIT License
4 stars 2 forks source link

Events: No navigation links if auto_item is disabled #10

Closed xchs closed 6 years ago

xchs commented 6 years ago

Affected version(s)

4.6+ (et al.)

Description No navigation links are generated if the option "_Enable autoitem" is deactivated in the system settings.

How to reproduce

To reproduce:

bytehead commented 6 years ago

I cannot reproduce this. Tested on Contao 4.6.6 and with sibling-navigation 1.1.8 with the Contao Official Demo. It works with enabled and disabled auto_item.

bytehead commented 6 years ago

The code which checks the auto_item is here: https://github.com/1up-lab/contao-sibling-navigation/blob/917f8a8fa3448cf4462dc9780b4fefb195b9942e/src/Helper/News/NewsHelper.php#L40-L43

and here: https://github.com/1up-lab/contao-sibling-navigation/blob/917f8a8fa3448cf4462dc9780b4fefb195b9942e/src/Helper/Event/EventHelper.php#L33-L36

xchs commented 6 years ago

Hm, I can still reproduce it. I've just repeated the test with version 1.1.9.

To reproduce:

bytehead commented 6 years ago

I could finally reproduce it, thanks! It only happens with Events. I have to dig a bit.

bytehead commented 6 years ago

1.1.10 is released, should be fixed in there. Thanks for reporting!

xchs commented 6 years ago

It now works flawlessly. Thanks a lot.