1whatleytay / saturn

A modern MIPS interpreter and assembler.
MIT License
29 stars 6 forks source link

Bitmap uses fallback protocol unless on 512x512 8x8 #19

Open cykadash opened 3 months ago

cykadash commented 3 months ago

It seems like the bitmap always uses the fallback protocol unless on 512x512 pixels and 8x8 units. I am on Linux if that makes a difference.

1whatleytay commented 3 months ago

Argh!! Yeah, linux is especially picky with custom Tauri protocols. This might also affect MIDI playback (since it uses a special protocol too). Going to investigate this in a VM this week.

1whatleytay commented 3 months ago

Out of curiosity, does smaller resolutions work? Like 32x32 1x1? For reference, 512x512 8x8 should be equivalent to 64x64 1x1, which is fairly small. Bitmap display units is more of a legacy feature, it was added to help people using MARS instructions (where units have a confusing but real meaning).

cykadash commented 3 months ago

Sorry just saw this, 32x32 1x1 does not work either, going to see if wine does the trick

1whatleytay commented 3 months ago

Hey, I've done some experimenting on a Linux VM and I've identified the issue. It's also worth noting this is a regression from around v0.1.7 time I think? So version v0.1.5 shouldn't have this problem (and I think v0.1.6 is good too).

The issue has to do with CORS and sending headers on Linux, if you're curious. Pretty cursed.

cykadash commented 3 months ago

Ohhh interesting, thank you

cykadash commented 3 months ago

Funnily enough the main reason why this bug is annoying is while debugging, yet v0.1.7 adds a lot of debugging features that I would be using.

1whatleytay commented 3 months ago

Hey, I've pushed a fix to the v0.1.9 branch. Should land about ~20 mins after this comment. Can you download it here https://github.com/1whatleytay/saturn/releases/tag/app-v0.1.9 and tell me if it works?

cykadash commented 3 months ago

Yes it works! Thank you so much