search

1wilkens / pam

Safe Rust API to the Linux Pluggable Authentication Modules (PAM)
https://docs.rs/pam/
Apache License 2.0
88 stars 36 forks source link

lib.rs: Make PamReturnCode field in PamError public #20

Closed mtlll closed 4 years ago

mtlll commented 4 years ago

The return code field in the PamError type isn't public. This means library users can't match on the specific error code.

1wilkens commented 4 years ago

LGTM, you are right PamError is kinda useless if you can't match on the error code. As this is a breaking change, could you add it to the CHANGELOG?

mtlll commented 4 years ago

There you go. Was unsure which type of change to note it as, but "Changed" seemed to fit the best.

1wilkens commented 4 years ago

Thanks, merged