search

2-complex / g2c

A cross-platform game development library.
MIT License
1 stars 0 forks source link

Consider renaming Player -> AudioPlayer #6

Open samgreen opened 10 years ago

samgreen commented 10 years ago

I think Player is a confusing class name in the context of a game engine. Despite your (anti)pattern of only naming classes one word.

2-complex commented 10 years ago

Agreed. While I think we both know there are worse things wrong with the engine, I shall do this now, because you made an issue.

My obsession with naming classes a single word comes from taking a different, more general design principal to a logical extreme: code makes more sense if it is divided into organizational units which reflect a natural mental model. We tend to give names to things which we think of as a unit, and single-word names to things we think of as a unit often... in general... in all of life. The logical extreme is: therefore single-word names are always better. I still believe the more general principal but I'll come off the single-word binge.

I value your input very much. Please make more issues.