TAStudio ArgumentOutOfRangeException at read-only movie end

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open a movie in read-only mode. For testing purposes, I used 
http://tasvideos.org/1715M.html .
2. Open TAStudio.
3. Wait until end of input.

What is the expected output? What do you see instead?
At end of input, an ArgumentOutOfRangeException is thrown; see 
http://bayimg.com/mAndLAAdg . After closing the exception dialog, Bizhawk 
crashes.

What version of the product are you using? On what operating system?
r1957, Win7 x64

Please provide any additional information below.

Original issue reported on code.google.com by stop.squark on 19 Mar 2012 at 2:33

[GoogleCodeExporter]

Fixed. TAStudio does substring operations on the movie mnemonic strings to set 
the controller pads. When the movie ends, the mnemonic strings are empty, and 
doing substring operations on an empty string is probably going to cause some 
out of range issues. I just added a condition to prevent this from happening 
and it seems to work.

Note: In your screenshot, your frame numbers are shown in full. For whatever 
reason, 5 digit numbers are displayed as 10..., 11..., etc. on my computer. I 
think this might have to do with my operating system and not any recent changes 
to TAStudio. Let me know if you don't have this issue on the latest revision.

Original comment by brandman...@gmail.com on 27 Mar 2012 at 7:53

• Changed state: Fixed

[GoogleCodeExporter]

Verified fixed in r2098; thanks. The problem with the TAStudio 5-digit frame 
count being displayed as XX... is because the frame column in the table is too 
narrow, in the screenshot I already worked around this problem by increasing 
the column size by dragging in the table header. I'll file a new issue for this.

Original comment by stop.squark on 30 Mar 2012 at 10:52