search

2000DTM / bizhawk

Automatically exported from code.google.com/p/bizhawk
0 stars 0 forks source link

Play movie: missing indication of checksum mismatch #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open Super Mario Bros. 3 (U) (PRG1) [!].nes .
2. Import and play http://tasvideos.org/1558M.html . Note it the movie was made 
on version PRG0.

What is the expected output? What do you see instead?
I expected some kind of indication that the checksum of the ROM and the 
checksum of the ROM used to make the movie do not match. Instead, there is 
nothing in the UI telling me that I am using the incorrect ROM.

I recorded and then played back a native Bizhawk movie in the same way and got 
the same result.

Please also include a warning dialog stating that I should expect desyncs, do I 
wish to continue [yes, no] when I click on the "Ok" button. Right now, it is 
possible to play a SMB3 movie on a SMB1 ROM.

What version of the product are you using? On what operating system?
r2164

Please provide any additional information below.

Original issue reported on code.google.com by stop.squark on 6 Apr 2012 at 9:10

GoogleCodeExporter commented 9 years ago 
r2187 adds a SHA-1 checksum to movie headers, presents it in the "Play movie" 
properties and highlights in red if there is a mismatch. This can be improved 
by providing the current ROM checksum like FCEUX, Snes9x-rr and vba-rr so they 
can be compared by the user.

Movie checksum verification still does not work for imported movies. This is to 
be expected, as SHA-1 checksums may not be present in the pre-imported movie 
header (e.g. .fm2 has MD5 only).

Original comment by stop.squark on 21 Apr 2012 at 10:24

GoogleCodeExporter commented 9 years ago 
Added a feature where a rom mismatch will enable a tooltip in the header list 
showing the current sha1. This in addition to accurate reporting of various 
mismatches (such as sha1 and system id) sufficiently closes this issue.

Let me know if there is any other issues with this (and if googlecode doesn't 
allow commenting on closed issues, let me know that too!)

Original comment by adeli...@tasvideos.org on 31 May 2012 at 1:18