2000DTM / bizhawk

Automatically exported from code.google.com/p/bizhawk
0 stars 0 forks source link

Non-zero Ram Watch items start with 1 change. #74

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open up Ram Watch.
2. Load a watch or add addresses.

What is the expected output? What do you see instead?
If the value for an address wasn't supposed to change in that frame, I would 
expect the changes to be set to 0. Instead, they are set to 1 unless the value 
is 0.

What version of the product are you using? On what operating system?
r3262

Please provide any additional information below.
Ram Search prevents this from happening by running PeekAddress for all of the 
addresses it initially shows for a search, setting all of the previous 
definitions to value, and zeroing out the changes list. If the same thing is 
done for adding a new watch, this should work.

Original issue reported on code.google.com by brandman...@gmail.com on 10 Jun 2012 at 5:40

GoogleCodeExporter commented 9 years ago
Fixing this would also make it so that watches automatically show their values 
when added. Currently, if you pause the emulator and add a watch to an existing 
list, that watch will have all 0s while the rest has valid values, which looks 
buggy.

Original comment by brandman...@gmail.com on 10 Jun 2012 at 4:56

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r2365.

Original comment by adeli...@tasvideos.org on 10 Jun 2012 at 5:45

GoogleCodeExporter commented 9 years ago
I'm on r2384 and this issue isn't completely fixed. The change might zero out 
upon opening and the initial value is shown, but the initial previous value is 
still displayed as 0, which is bizarre because I'd imagine the previous value 
would equal the current value for the change count to remain as zero on the 
next frame when it updates.

Original comment by brandman...@gmail.com on 11 Jun 2012 at 11:53

GoogleCodeExporter commented 9 years ago
Fixed previous value

Original comment by adeli...@tasvideos.org on 12 Jun 2012 at 12:39

GoogleCodeExporter commented 9 years ago
Acknowledged this is now fixed.

Original comment by brandman...@gmail.com on 14 Jun 2012 at 12:05