2006-Scape / 2006Scape

A 2006 Runescape Emulation Server
https://2006Scape.org
GNU General Public License v3.0
184 stars 160 forks source link

Various Doors #547

Open halogod35 opened 1 year ago

halogod35 commented 1 year ago

These doors change textures when opened and closed

Varrock Castle Library: Closed ID: 1512 Closed X,Y: 3209, 3490 Opened ID: 1513 Opened X,Y: 3209, 3489 java_875qETnaAY Dwarven Mines: (Just the west door) Closed ID: 3 Closed X,Y: 3015, 3453 Opened ID: 4 Opened X,Y: 3014, 3453 java_m4NCykTQYG Western Ardougne: Closed ID: 2556 Closed X,Y: 2610, 3316 Opened ID: 2557 Opened X,Y: 2611, 3316 java_nCegJCmWYr

These doors have some mistake to them:

Ardougne General Store: door seems to be installed wrong Closed ID: 1533 Closed X,Y: 2614, 3294 (Should be 2614, 3295) Opened ID: 1534 Opened ID: 2614, 3295 (Should be 2614, 3296) java_ofBTaoUSqI Varrock Castle Kitchen: different textures for the same door NE Door ID: 1514 NE Door X,Y: 3224, 3493 S Door ID: 1512 S Door X,Y: 3223, 3491 java_tEEXMKZ1W5 Wizard's Tower: Closed ID: 11993 Closed X,Y: 3107, 3162 Open ID & X,Y: Same java_GyRdDwGe1h Al-Kharid Palace (West): N Door is fine, S door can't be selected once opened N Closed ID: 1506 N Closed X,Y: 3287, 3172 N Open ID: 1507 N Open X,Y: 3286, 3172 S Closed ID: 1508 S Closed X,Y: 3287, 3171 S Open ID: ???? (Probably 1509) S Open ID: ???? (Probably 3286, 3171) java_TIzTkr9AaR Al-Kharid Palace (East): Same door problem as above N Closed ID: 1508 N Closed X,Y: 3298, 3172 N Open ID: ???? (Probably 1509) N Open X,Y: ???? (Probably 3299, 3172) S Closed ID: 1506 S Closed X,Y: 3298, 3171 S Open ID: 1507 S Open ID: 3299, 3171 java_AYMUREUCU6 Al-Kharid Palace (South): Doors teleport player instead of opening W Closed ID: 1506 W Closed X,Y: 3292, 3167 E Closed ID: 1508 E Closed ID: 3293, 3167 java_FoG89J9362 Port Sarim Gold Shop: Closed ID: 59 Closed X,Y: 3016, 3246 Open ID: None? Open X,Y: None? java_uKqQH3AOcb Ranging Guild: Closed ID: 2514 Closed X,Y: 2658, 3438 Open ID & X,Y: Same (GIF)

MatthewBishop commented 1 year ago

In the bottom left corner there is the second wrench Icon. Within it it has an option to show debug information. If you enable that setting and then Right click the door while open and closed it is a huge help since that would show the door object id and x/y location.

halogod35 commented 1 year ago

Absolutely, I updated the report with their IDs and Locations.

MatthewBishop commented 1 year ago

Thanks a bunch! Most of these are because the way we handle doors is pretty naive. It just adds 1 to the object id to open them. This works in a lot of scenarios but there are fringe cases. If we load https://gitlab.com/2009scape/2009scape/-/blob/master/Server/data/configs/door_configs.json server sided it should fix most of these issues.