search

2009scape / 2009scape.github.io

A remake of the 2009 era Runescape Website
https://2009scape.org/
26 stars 39 forks source link

Use templates better to remove a ton of code duplication #254

Closed PureTryOut closed 5 months ago

PureTryOut commented 10 months ago

Where it made sense I converted HTML pages to Markdown to ease writing and discourage custom styling as much as possible. These pages can still use custom HTML when necessary, and some do, but they are easier to read and understand now.

4,882 additions and 12,273 deletions.

Those are the numbers we like to see, love it.

PureTryOut commented 10 months ago

@Ceikry anything holding this back?

dginovker commented 9 months ago

@ryannathans Any opinion? I say we yeet it in

ryannathans commented 9 months ago

There are a lot of changes, does this impact my update script MR?

PureTryOut commented 9 months ago

It doesn't. The PR that does though is https://github.com/2009scape/2009scape.github.io/pull/243 which has already been merged, and https://gitlab.com/2009scape/2009scape/-/merge_requests/1710 updates your update script. There is no mention of this script in this repo btw so I had no clue it existed. Is there any reason for not having it in this repo instead of in the server one?

PureTryOut commented 9 months ago

@ryannathans and @Ceikry is there anything left to do here?

downthecrop commented 9 months ago

looks good to me.