search

200ok-ch / org-parser

org-parser is a parser for the Org mode markup language for Emacs.
GNU Affero General Public License v3.0
316 stars 15 forks source link

Fix drawer-end-line not parsed #25

Closed rollacaster closed 3 years ago

rollacaster commented 3 years ago

Since drawer-begin-line had a higher priority than drawer-end-line all end lines have been parsed as begin lines.

This issue was already found in #6 and a solution which includes fixing the parsing of the property-line was already started. But the issue with the end-line can be fixed without a proper property-line parsing.

schoettl commented 3 years ago

Thank you, good catch! Looks good to me.

Hey @rollacaster, if you plan to work more on org-parser, and if you have time and the topic is interesting for you, you could have a look at my PR #11.

I started it months ago ago but currently I have no time to finish it. There are some failing tests, and my fear is that with upcoming changes it will get harder and harder to rebase/merge it. Otherwise, I hope I can come back to it in my next semester holidays...

schoettl commented 3 years ago

PS: You're from Munich? I also study there at HMTM ;)

rollacaster commented 3 years ago

Hello @schoettl!

Since I'm not really familiar with instaparse, I'm afraid I can't easily help with #11.

Also, for my current use case, line-based parsing with some post-transforms using clojure.core and clojure.zip works quite well , so I plan to fix some issues around line parsing as soon as I stumble upon them.

PS: Yes, I am also from Munich 🙂 .

munen commented 3 years ago

@rollacaster This looks good to me, thank you for the fix! :pray:

Merging while closing #11.