Upstream compatibility: nonstandard enum sizes

200sc / bebop

bebop wire format in Go

Apache License 2.0

71 stars 5 forks source link

Upstream compatibility: nonstandard enum sizes #24

Closed 200sc closed 1 year ago

200sc commented 2 years ago

c.f. https://github.com/RainwayApp/bebop/issues/156

sveinnthorarins commented 1 year ago

Any plans to implement this?

200sc commented 1 year ago

@sveinnthorarins PR is up covering this, if you're actively attempting to use this feature and want to verify it before I cut a new version.

sveinnthorarins commented 1 year ago

Yeah, I left a comment on the PR.

However, I only just came across bebop (and your package) a few days ago, so I am no expert. I'm sure writing up some very basic test cases using custom sized enums in all possible ways will cover much more ground than my current .bop file does 😅

Ooh, and thank you for working on this 🙏

200sc commented 1 year ago

@sveinnthorarins I added the new enums to the compatibility test suite after adjusting the generated writers, thanks! I've merged this in as a pre-release v0.4.0 for now.