Feature/multiple array suffix

200sc / bebop

bebop wire format in Go

Apache License 2.0

71 stars 5 forks source link

Feature/multiple array suffix #32

Closed 200sc closed 2 years ago

200sc commented 2 years ago

This changeset:

Adds missing support for field types with multiple [] suffixes e.g. byte[][][] bytes
Updates internal compatibility tests with rainway to 2.4.9.

Closes #31

merlindru commented 2 years ago

I haven't tested this, but I'd love to see this land! Do you want/need me to test it?

merlindru commented 2 years ago

As always, thank you for the incredibly fast turnaround time 😄 And seriously, hats off for maintaining this awesome lib

200sc commented 2 years ago

@merlindru Thanks! Yes, I left it up for you to verify, but if you're happy I'll merge it with a version bump

merlindru commented 2 years ago

Give me a minute to test it out

merlindru commented 2 years ago

@200sc Tested both uint8[][][] and array[array[array[uint8]]], works perfectly fine!

Just for fun, I shoddily tested a nesting of 1024 levels, which resulted in a 20k line file (ls -lh reports it as 29M large) and it was still in the single-digit seconds (for both generating and writing to disc)