201-created / ember-cli-acceptance-test-helpers

A set of useful test helpers for ember acceptance tests.
https://www.npmjs.com/package/ember-cli-acceptance-test-helpers
MIT License
47 stars 17 forks source link

Ember 1.11 #12

Closed iezer closed 9 years ago

iezer commented 9 years ago

@bantic For you, fix using Ember.View.views as you suggested.

bantic commented 9 years ago

@iezer a test failure. I imagine that Ember.View.views lists all views, whether they are on the page or not, so it's erroneously reporting true for a component that is in memory (in Ember.View.views) but not shown on the page. I think that's why this test is failing.

iezer commented 9 years ago

@bantic That issue was actually because I fixed what I thought was a typo tehre -> there. Happy to add another test but what's the best way to add a view that is not on the page? would it work to add a component and set display: none in CSS, or put the component in an if block that flips from true to false?

bantic commented 9 years ago

@iezer Yeah, adding another route to the dummy app would be the easiest way to do this. Move most of what is in the dummy application.hbs into an index.hbs file, then add another route to the dummy router that does not have that component and confirm that the appropriate test passes there

bantic commented 9 years ago

and add an {{outlet}} to application.hbs

bantic commented 9 years ago

@iezer boo-yah!