search

2011Scape / game

An open-source emulator that targets RuneTek-5, client revision 667 (October 4th, 2011)
http://2011scape.com
Apache License 2.0
32 stars 131 forks source link

feat: beautify login message #499

Closed DesecratedTree closed 7 months ago

DesecratedTree commented 7 months ago

What has been done?

feat: beautify login message

Has your code been documented?

ye

ultraviolet-jordan commented 7 months ago

I don't think instructions are clear enough.

HarleyGilpin commented 7 months ago

Thank you for your pull request. After careful consideration, we have decided not to merge your proposed changes. Replacing the login message with the RuneScape name does not align with the goals and user experience we aim to maintain in our project.

In the future, please consider the following principles before submitting a pull request:

  1. Relevance and Alignment with Project Goals: Ensure that your changes are relevant to the project's objectives and overall vision. Each feature or modification should add value and enhance the user experience or functionality.
  2. Simplicity and Clarity: Aim for simplicity. Unnecessary complexities or changes that could confuse users are generally not favorable. The code should be clear and well-documented.
  3. Quality and Testing: High-quality code that is thoroughly tested reduces the chance of introducing bugs. Ensure your code adheres to our coding standards and includes appropriate tests.
  4. User Impact: Consider the impact of your changes on the end-users. Enhancements should be user-centric, improving usability, accessibility, or performance.
  5. Documentation: Any new feature or significant change should be accompanied by corresponding updates in the documentation, explaining how to use the new functionality.
  6. Community Consensus: It's advisable to discuss changes with the community or maintainers before putting effort into changes. This can be done through GitHub issues, discord or our discussion forums.

We appreciate your effort and encourage you to keep these principles in mind for future contributions. If you have any questions or need guidance on a potential feature, feel free to reach out to us.