fix: combination action checks proper skill and not just crafting

2011Scape / game

An open-source emulator that targets RuneTek-5, client revision 667 (October 4th, 2011)

http://2011scape.com

Apache License 2.0

32 stars 131 forks source link

fix: combination action checks proper skill and not just crafting #516

Closed Ilwyd closed 6 months ago

Ilwyd commented 6 months ago

What has been done?

Fixed the CombinationAction canCombine function to check the CombinationData's skill and not just crafting

Before

After

Has your code been documented?

Yes

Ilwyd commented 6 months ago

On line 26 - player.addXp(Skills.CRAFTING, data.experience)

Lets make sure we are using the skill from CombinationData, so that the correct experience is given to the player. Otherwise great work, just keep an eye on your edge cases.

Good catch, fixed