Use openshift-ansible cloud provider config.

2015-Middleware-Keynote / demo-ansible

Apache License 2.0

18 stars 24 forks source link

Use openshift-ansible cloud provider config. #114

Closed abutcher closed 8 years ago

abutcher commented 8 years ago

detiber commented 8 years ago

nice!

abutcher commented 8 years ago

Missed the max-pods config -- adding that shortly.

abutcher commented 8 years ago

Added max-pods

kubeletArguments:
  cloud-config:
  - /etc/origin/cloudprovider/aws.conf
  cloud-provider:
  - aws
  max-pods:
  - '100'

detiber commented 8 years ago

Man, we don't expose max_pods as a separate variable yet?

abutcher commented 8 years ago

Nope.jpeg

thoraxe commented 8 years ago

I don't understand what this PR does...

abutcher commented 8 years ago

It does what the removed lines did.

On Thursday, March 31, 2016, Erik M Jacobs notifications@github.com wrote:

I don't understand what this PR does...

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/2015-Middleware-Keynote/demo-ansible/pull/114#issuecomment-204192826

alberttwong commented 8 years ago

@abutcher I guess the confusion is that you removed lines but didn't add more instructions/files or added lines

abutcher commented 8 years ago

Hey @alberttwong, AWS cloud provider settings were added to openshift-ansible in the PR linked in the description so we can simply set openshift_cloudprovider_kind: aws (since demo-ansible utilizes iam profiles there's no need to provide keys)

alberttwong commented 8 years ago

I see... so we're removing legacy settings and technical debt. Got it.

thoraxe commented 8 years ago

Testing now.

thoraxe commented 8 years ago

This does not work against openshift-ansible-3.0.47-6 -- /etc/origin/aws.conf is not properly created.

abutcher commented 8 years ago

Relies on the associated 3.2 openshift-ansible release for packaged ansible scripts. (or the next release which will probably be 3.2)