2015-Middleware-Keynote / demo-ansible

Apache License 2.0
18 stars 24 forks source link

error while evaluating conditional: deployment_type #54

Closed ryanj closed 8 years ago

ryanj commented 8 years ago

@burrsutter and I are both seeing this error while attempting to create environments using the latest demo-ansible (cb37666) and openshift-ansible (34465b6):

TASK: [os_firewall | Install firewalld packages] ****************************** 
fatal: [ec2-52-23-211-8.compute-1.amazonaws.com] => error while evaluating conditional: deployment_type in ['enterprise','openshift-enterprise','origin']
ryanj commented 8 years ago

The roadshow environments are currently using openshift-ansible at 3efe322 - https://github.com/openshift/openshift-ansible/commit/3efe322c2621e1ba19a5bfc1e7b13bb8bd1177ef

For a short-term workaround switch to that commit of openshift-ansible:

cd ../openshift-ansible
git checkout 3efe322c2621e1ba19a5bfc1e7b13bb8bd1177ef
cd -

Then re-run your playbook script.

ryanj commented 8 years ago

Hmm... that didn't seem to fix things. The script hits an error while pulling down the base / builder images.

ryanj commented 8 years ago

Any ideas @thoraxe. @sdodson?

sdodson commented 8 years ago

Yes, add deployment_type='origin' or deployment_type='enterprise' to your inventory with the value you'd like.

ryanj commented 8 years ago

I tried adding each of the following to my inventory/aws/hosts/ec2.ini file, but I didn't find a winning combo:

deployment_type='enterprise'
deployment_type = enterprise
deployment_type = openshift-enterprise
[OSEv3:vars]
deployment_type = enterprise
thoraxe commented 8 years ago

Are you doing this on your own machine? On Sep 25, 2015 14:36, "ryan jarvinen" notifications@github.com wrote:

I tried adding each of the following to my inventory/aws/hosts/ec2.ini file, but I didn't find a winning combo:

deployment_type='enterprise'

deployment_type = enterprise

deployment_type = openshift-enterprise

[OSEv3:vars] deployment_type = enterprise

— Reply to this email directly or view it on GitHub https://github.com/2015-Middleware-Keynote/demo-ansible/issues/54#issuecomment-143317289 .

burrsutter commented 8 years ago

I am running the demo-ansible playbook from my laptop but targeting EC2 - do you feel like running the playbook from a EC2 running VM would be better?

thoraxe commented 8 years ago

Not necessarily related. I wasn't sure if Ryan was using our pre staged environment which has an older version of this repo and the installer repo. On Sep 25, 2015 2:42 PM, "Burr Sutter" notifications@github.com wrote:

I am running the demo-ansible playbook from my laptop but targeting EC2 - do you feel like running the playbook from a EC2 running VM would be better?

— Reply to this email directly or view it on GitHub https://github.com/2015-Middleware-Keynote/demo-ansible/issues/54#issuecomment-143318478 .

ryanj commented 8 years ago

I've been using my laptop and targeting my personal EC2 account in order to work on a fix (based on the latest master branches). I think I have one ready (#55).

Anyone care to give #55 a quick look?

I was going to verify the fix using our shared Roadshow environment next. If the branch runs well over there, then I'll probably go ahead and merge (barring any objections).

thoraxe commented 8 years ago

Please do not change the roadshow environment. On Sep 25, 2015 4:46 PM, "ryan jarvinen" notifications@github.com wrote:

I've been using my personal EC2 account work on a fix. I think I have one ready (#55 https://github.com/2015-Middleware-Keynote/demo-ansible/pull/55).

Anyone care to give #55 https://github.com/2015-Middleware-Keynote/demo-ansible/pull/55 a quick look?

I was going to verify the fix using our shared Roadshow environment next. If the branch runs well over there, then I'll probably go ahead and merge (barring any objections).

— Reply to this email directly or view it on GitHub https://github.com/2015-Middleware-Keynote/demo-ansible/issues/54#issuecomment-143349295 .

ryanj commented 8 years ago

@thoraxe np, I'm happy to let you handle that work. I'm running a Roadshow on Monday, so I was hoping to get the fix implemented before everyone leaves for the weekend.

detiber commented 8 years ago

Closing, since I believe this has already been addressed.