search

2015-Middleware-Keynote / demo-ansible

Apache License 2.0
18 stars 24 forks source link

[rfe] combine register and post register #74

Closed thoraxe closed 8 years ago

thoraxe commented 8 years ago

Does anyone remember/recall why we have separated register_hosts and post_register?

Especially if we're doing these in serial, it might make sense to do them all in one playbook. It can make big environments take quite a long time.

detiber commented 8 years ago

I do not recall other than it might have been an attempt to share common code between rhsm hosts and non-rhsm hosts.

In reality, we should probably leverage the subscription bits in openshift-ansible and use the repos variable for non-rhsm.

thoraxe commented 8 years ago

There are subscription bits in openshift-ansible now?

detiber commented 8 years ago

@thoraxe The original code was contributed by Amadeus and modified by @codificat, but I'm not sure I want to tackle modifying it to update for 3.1 (and future versions) quite yet... Haven't put in enough thought on how to properly do it yet.

For now, I think keeping the demo-ansible registration bits separate is a good idea.

thoraxe commented 8 years ago

That's fine. What about combining the sub and repo-based activities into one playbook though?

detiber commented 8 years ago

Already done in my PR. Stuck on getting the registration stuff sorted out right now (skipping re-reg on subsequent runs) On Dec 21, 2015 5:16 PM, "Erik M Jacobs" notifications@github.com wrote:

That's fine. What about combining the sub and repo-based activities into one playbook though?

— Reply to this email directly or view it on GitHub https://github.com/2015-Middleware-Keynote/demo-ansible/issues/74#issuecomment-166438680 .

detiber commented 8 years ago

Closing now that https://github.com/2015-Middleware-Keynote/demo-ansible/pull/75 has merged