search

2016rshah / bookshelf

:books: Showcase the books you have read.
http://bookshelf.rshah.org/users/1
10 stars 7 forks source link

Initial design changes #1

Closed kennethlarsen closed 8 years ago

kennethlarsen commented 8 years ago

Initial design changes - I will keep working on the design but this should do the trick for now. Let me know what you think.

2016rshah commented 8 years ago

Oh wow this is great, I didn't even know you were working on this! I have a few comments, but I can't wait to merge this.

Colors

I really like the color you picked for the notification bar, would it be possible to switch the main header/footer color with the notification bar color? Like have notifications show up in the #F1654C and have the header footer show up in #00B5B5?

Header and Footer

Also, would it be possible to make the footer a bit more inconspicous? Like maybe half the height of what it currently is or like the same size as the header. Right now I just think the footer is unnecessarily tall.

Mobile

And finally, the header and footer don't center text vertically on mobile/small screens

Here's an example of what I'm talking about on the header

screen shot 2015-11-27 at 5 27 21 pm

And the corresponding footer

screen shot 2015-11-27 at 5 28 42 pm
kennethlarsen commented 8 years ago

Awesome! I will look into the changes :)

kennethlarsen commented 8 years ago

My latest commits should fix your requests :)

2016rshah commented 8 years ago

Great work! If you would like to keep working on the project, I would love your help! Just let me know if you're up for it.

kennethlarsen commented 8 years ago

Thanks! Yeah I would love to help out.

2016rshah commented 8 years ago

Okay well perhaps with the new design changes would you like to take a screenshot and update the README?

Also, do you have experience with Ruby and Rails, or are you mostly a designer?

kennethlarsen commented 8 years ago

I updated the readme with a new screenshot.

I know some Ruby on Rails but I'm mainly a frontend developer so my Ruby on Rails code might not be the prettiest.