2018-BGMP / demultiplexing-maddygriz

demultiplexing-maddygriz created by GitHub Classroom
0 stars 0 forks source link

Mitch Peer Review #2

Open mrezzoni opened 6 years ago

mrezzoni commented 6 years ago

Very thorough descriptions of higher-order functions and unit tests. Your higher-order functions are efficient and facilitate succinct code. I think I understand your readReads function but I didn't see it explicitly defined in either document. I'm not sure if I understand the purpose of concatenating the index onto the + line...it might also violate the conventions of a fastq file. Nice job distinguishing between forward and reverse reads. Filtering for quality in this portion of the assignment might be superfluous. Consider implementing the containsN function as a separate if statement after you finish matching: if matching(index1, index2): do stuff else: do other stuff if containsN(index1, index2): do stuff Is index 2 intentionally omitted at the end? Make sure you return the number of properly matched indexes and level of index hopping.