search

2018-BGMP / demultiplexing-maddygriz

demultiplexing-maddygriz created by GitHub Classroom
0 stars 0 forks source link

Carolyn's feedback #3

Open 0x644BE25 opened 6 years ago

0x644BE25 commented 6 years ago

Nice work, very thorough! Your functions seem reasonable, and the way you've laid it out would make it very neat and organized for implementing.

I like that you save the indices and reason for rejection in the bad reads file.

I didn't see anything to calculate and return your output (how many read pairs per index, what % index hopping). Sorry if it was there and I missed it!

0x644BE25 commented 6 years ago

Ah! It also just occurred to me that the way you have it now, bad reads will only get tagged with the first reason they get rejected. So a read with a mismatched indices AND low quality will only get tagged as having mismatched indices. Probably not a big deal, but something to be aware of.