2018-BGMP / demultiplexing-maddygriz

demultiplexing-maddygriz created by GitHub Classroom
0 stars 0 forks source link

David's Review Brought to you by David. David did this one. #4

Open David-Degnan opened 6 years ago

David-Degnan commented 6 years ago

Maddy

• Does the proposed algorithm make sense to you? Can you follow the logic? The proposed algorithm makes sense to me and I can follow the logic. I saw that good, better, and best file is defined at the top of the pseudocode but I do not best used in the actual pseudocode description.

• Does the algorithm do everything it's supposed to do? The following things are accounted for the in the algorithm: sorting reads by index, outputting one forward file and one reverse file per index and including a pair of files for unknown indexes. I am not sure where the number of properly matched indices or the level of index hopping is described in the pseudo code. The hopping counter is increased, but how are non-hopped reads accounted for and hopping levels?

• Are proposed functions reasonable? Are they "standalone" pieces of code? The functions are reasonable, well-written, and standalone pieces of code. Great job!