search

202-ecommerce / stripe_official

After years of hard work with Stripe connector for PrestaShop, 202 ecommerce stop the development of Stripe module on January 9th 2023. Thanks for all contributors that help us!
20 stars 20 forks source link

Orders are marked as "payment received" a second time - after order was already shipped #113

Closed icemansparks closed 2 years ago

icemansparks commented 2 years ago

The problem resulted in us shipping orders multiple times since the order status was set to "payment received" when we opened the shop. We only noticed because of an individualised product that we could not image the customer would order twice.

Prestashop version 1.7.8.2 Module Version 2.4.1

Orders payed with stripe module (Klarna and Credit card) seem to be set to "payment received" multiple times, even though the order was already shipped. SCR-20220203-mae

We again had to deactivate the stripe module in the shop because of those errors.

There is only one entry for the "id_stripe" value in "ps_stripe_payment" table and also only one entry in "ps_stripe_payment_intent" table - but table "ps_stripe_event" shows the following values for the corresponding id_payment_intent: SCR-20220203-mne

The actions on 27th seem to already have set the "payment received" order state while the action on 29th (authorized) again triggered this order state. Pretty sure this should not be set twice and the first one probably should be a "waiting for payment" order state instead of "payed" ?

icemansparks commented 2 years ago

I may just have found the problem (by looking at a similar issue here on github). The value for STRIPE_OS_SOFORT_WAITING in ps_configuration was set to "2" in our database - since order_state_id=2 is "payment received" - this may have been the culprit entry.

Can anyone tell me if this value should really be "2", or what the correct order_state_id would be for this configuration value?

clotairer commented 2 years ago

Hi,

The status corresponding to STRIPE_OS_SOFORT_WAITING sould be a specific state created during the installation of the module that named "Awaiting for Sofort payment" https://github.com/202-ecommerce/stripe_official/blob/f24f07f895f13f2752ce56798137081698b02e6f/stripe_official.php#L596

The property of this step sould be:

This state is not delivered, not paid, ...

Do you have this state on your PrestaShop ?

icemansparks commented 2 years ago

Hi @clotairer thank you so much for the immediate response and the details as well!

The state that you described was not present in our shop - i created it now with ID = 31 and the correct values that you posted (cross referenced with a freshly set up test-shop).

I will now set the value for STRIPE_OS_SOFORT_WAITING in ps_configuration to the value 31 to match the state as needed.

clotairer commented 2 years ago

OK we will check to this parameter during installation.