202-ecommerce / stripe_official

After years of hard work with Stripe connector for PrestaShop, 202 ecommerce stop the development of Stripe module on January 9th 2023. Thanks for all contributors that help us!
20 stars 20 forks source link

Unexpected problem on credit card payment since version 2.3.1 #146

Closed darkstudio closed 2 years ago

darkstudio commented 2 years ago

Hi, Prestashop 1.7.5.6 PHP 7.3 Stripe 2.3.1

I have already mention this bug bug i am always stuck since many month in version 2.3.1 of stripe module. When we update on any version after 2.3.1 (i have just tried 2.4.3), we have a error message on last step. To avoid make reccurent problem on the live website, we have clone the prestashop localy to make tests. bug_stripe

Very annoying.

clotairer commented 2 years ago

Could you send us a message to the support team with reference github issue #146 and with data of the table stripe_official_processlogger ? This error catch all error like issues to contact Stripe API, ...

darkstudio commented 2 years ago

Additonnaly (for other people), when i use "bancontact", i have an other error message image

clotairer commented 2 years ago

Could you please create an other issue ? We make some effort to have "release issue" to inform the community of fixes and it's easier to linked issue and commit if we have only one issue on each ticket. Thank you.

lmeyer1 commented 2 years ago

I have the same problem. With version 2.4.4, the error message is An unexpected problem has occurred. Please contact the support.. In addition, there is nothing logged in the table ps_stripe_official_processlogger.

lmeyer1 commented 2 years ago

@clotairer The error occurs here https://github.com/202-ecommerce/stripe_official/blob/5631793cf2e3645440ccd2494a0ca431f0615225/controllers/front/createIntent.php#L307. That means that $stripeEvent cannot be saved.

lmeyer1 commented 2 years ago

@clotairer @darkstudio The root problem is that the update scripts have not been run. (i.e. the table ps_stripe_event is missing.) Is there a way to rerun them ?

clotairer commented 2 years ago

The reset of the module sould install tables, and verify hooks.

An other way is to add these line in the getContent() method and call the configuration page one time (and remove this after):

        $installer = new Stripe_officialClasslib\Install\ModuleInstaller($this);
        $installer->install();
lmeyer1 commented 2 years ago

@clotairer Thanks. It worked. I had to review the configuration and save to regenerate the webhooks. No everything is OK.

clotairer commented 2 years ago

The remain problem is why do you have an Stripe without ps_stripe_event table ? Is there a problem during the last upgrade of the module ?

lmeyer1 commented 2 years ago

The problem was that I was deploying directly from git. So it's the fault of the way I'm working. It is not related to the module.

clotairer commented 2 years ago

So, @darkstudio perhaps you can try this and tell us if it's better.

The reset of the module sould install tables, and verify hooks.

An other way is to add these line in the getContent() method and call the configuration page one time (and remove this after):

        $installer = new Stripe_officialClasslib\Install\ModuleInstaller($this);
        $installer->install();
darkstudio commented 2 years ago

Ok error message gone but 2 new bug:

1) The payment is not captured even if the module is configured for and after payment confirmation, it will return to order history not the payment confirmation notice and the cart is not cleared. image image

2) some payment method is not showed even is activated on module image image image

luckily I'm working on a local copy! I've had enough trouble with this module

clotairer commented 2 years ago

The payment is not captured even if the module is configured for and after payment confirmation, it will return to order history not the payment confirmation notice and the cart is not cleared.

@Afayadas work on it this week. We will add a fix probably next week to publish the 2.4.4 final release

some payment method is not showed even is activated on module

Are they enabled on your Stripe Dashboard ? Your shipping/invoice address is set to the corresponding country (Germany for Giropay, ...) ?

darkstudio commented 2 years ago

@clotairer yes..my bad. if i create multiple adresse with different country, multiple payement is showed but not usable because i have a error message which say that paymentintents must be capture_method=automatic (it is on module). i suppose that this is the issue will be fixed by @Afayadas on version 2.4.4 final release. image

clotairer commented 2 years ago

Sofort have the same issue and it was fixed in PR #122. Bancontact and EPS have a redirect flow, perhaps it still remain an issue for these payment.

We will verify it.

clotairer commented 2 years ago

@darkstudio The last issue you met should be fixed by this PR #161

clotairer commented 2 years ago

2.4.5-RC1 released here and can be downloaded to test.

Thank you.