Sam-Koehler
commented
4 years ago Great review Eric! Really appreciate you pointing out my need for a reverse-complement function, I'll be sure to implement that.
Open traneric opened 4 years ago
Sam-Koehler
commented
4 years ago Great review Eric! Really appreciate you pointing out my need for a reverse-complement function, I'll be sure to implement that.
Hi, Sam! Here's my review of your pseudocode.
Great work defining the problem and output. I liked how you describe the contents of each of the four inputput files. This made it easy to understand what you were trying to accomplish with the program.
A function to determine the reverse complement of your indexes would've been useful. Since we'll be doing this several times throughout the program, it will be beneficial to compartmentalize this step into a function.
How will your algorithm extract indexes from R2 and R3. Are you using loops and/or particular library to accomplish this? I thought you could've elaborated more on the logic here.
I don't see a counter for the number of index-pairs, read-pairs with index-hopping, and read-pairs with unknown indexes. Were these included in your pseudocode? Maybe I missed it somewhere?
Does the proposed algorithm make sense to you? Can you follow the logic?
The algorithm is clear and easy to follow! I really like the amount of details you put into your descriptions. The filters in particular made a lot of sense and it was very easy to follow the overall logic of your algorithm.
Does the algorithm do everything it's supposed to do? (see list of requirements in Assignment the First)
[X] Problem Defined [X] File Outputs Described [X] Unit Tests [X] Algorithm Provided [X] The functions were clearly defined with their own set of descriptions!
Are proposed functions reasonable? Are they "standalone" pieces of code?
Yes, the proposed functions are reasonable and are standalone pieces. Great work including a description for each function.
Overall nice job, Sam!
░░░░░░░░░░░░░░░░░░░░░░█████████ ░░███████░░░░░░░░░░███▒▒▒▒▒▒▒▒███ ░░█▒▒▒▒▒▒█░░░░░░░███▒▒▒▒▒▒▒▒▒▒▒▒▒███ ░░░█▒▒▒▒▒▒█░░░░██▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒██ ░░░░█▒▒▒▒▒█░░░██▒▒▒▒▒██▒▒▒▒▒▒██▒▒▒▒▒███ ░░░░░█▒▒▒█░░░█▒▒▒▒▒▒████▒▒▒▒████▒▒▒▒▒▒██ ░░░█████████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒██ ░░░█▒▒▒▒▒▒▒▒▒▒▒▒█▒▒▒▒▒▒▒▒▒█▒▒▒▒▒▒▒▒▒▒▒██ ░██▒▒▒▒▒▒▒▒▒▒▒▒▒█▒▒▒██▒▒▒▒▒▒▒▒▒▒██▒▒▒▒██ ██▒▒▒███████████▒▒▒▒▒██▒▒▒▒▒▒▒▒██▒▒▒▒▒██ █▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒█▒▒▒▒▒▒████████▒▒▒▒▒▒▒██ ██▒▒▒▒▒▒▒▒▒▒▒▒▒▒█▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒██ ░█▒▒▒███████████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒██ ░██▒▒▒▒▒▒▒▒▒▒████▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒█ ░░████████████░░░█████████████████