search

2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

Added query string #127

Closed yjjw closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #127 (e3de070) into main (648d2aa) will decrease coverage by 0.19%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   99.09%   98.89%   -0.20%     
==========================================
  Files           7        7              
  Lines         440      453      +13     
==========================================
+ Hits          436      448      +12     
- Misses          4        5       +1
Impacted Files Coverage Δ
service/models.py 100.00% <100.00%> (ø)
service/routes.py 99.61% <100.00%> (-0.39%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 648d2aa...e3de070. Read the comment docs.

kdokm commented 2 years ago

Thank you for the work! But I do not quite understand why is the test for find_item_not_found_item is commented out?

yjjw commented 2 years ago

Thank you for the work! But I do not quite understand why is the test for find_item_not_found_item is commented out?

My bad, accidentally commented out that part of test. Have put the test back. Thanks for noticing this!