2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

decreased dev instances to make elephantsql more reliable #128

Closed TimothyXu closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #128 (ab3ea2e) into main (648d2aa) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files           7        7           
  Lines         440      440           
=======================================
  Hits          436      436           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 648d2aa...ab3ea2e. Read the comment docs.

kdokm commented 2 years ago

Sorry that I do not know things about cloud deployment very well. Do we also want to decrease the number of instances for prod? In addition, do we already have two instances of db (one for dev and prod, one for test) now?

TimothyXu commented 2 years ago

You can inspect the pipeline I've set up here: https://cloud.ibm.com/devops/pipelines/83c3c46e-34fb-47ec-9f72-65c9bef9f6df?env_id=ibm:yp:us-south We have 3 ElephantSQL db instances actually even better. One for dev, one for prod, one for nosetests. I figured prod should still have 2 instances to prevent failures since that's the real app that the business will use; dev is probably okay to only have 1 instance running (it's only for internal testing & development) so I made that choice so that the behave BDD tests against it are more reliable, since free ElephantSQL dbs limit incoming connections to 2. Not too important