2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

ui for resume. fixed error in hold_item #133

Closed TimothyXu closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #133 (dabc77e) into main (5a9ac2f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #133   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files           7        7           
  Lines         453      453           
=======================================
  Hits          449      449           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a9ac2f...dabc77e. Read the comment docs.

TimothyXu commented 2 years ago

In UI for Hold, @kdokm you tried to display the item changed in the search box but it doesn't actually work; if you try it on the UI it just shows null null null null null. That feature isn't really necessary any way so I commented out that part of the code; if you know how to fix it you are welcome to make that work (and I can add it to resume item ui too for consistency).

I also changed a parseInt to parseFloat in add_items UI which is currently being worked on by @Adora2401, just in case that error may not be tested by the BDD tests we have written. I will add another test to add_items UI too. (Done in ZenHub, just changed one of them to have a float price instead of int price)

Adora2401 commented 2 years ago

In UI for Hold, @kdokm you tried to display the item changed in the search box but it doesn't actually work; if you try it on the UI it just shows null null null null null. That feature isn't really necessary any way so I commented out that part of the code; if you know how to fix it you are welcome to make that work (and I can add it to resume item ui too for consistency).

I also changed a parseInt to parseFloat in add_items UI which is currently being worked on by @Adora2401, just in case that error may not be tested by the BDD tests we have written. I will add another test to add_items UI too.

Thanks Timothy, I just saw the message and will fix the conflicts later