search

2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

initial working version of UI-Create-Item #134

Closed Adora2401 closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #134 (18f1567) into main (e50b9da) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #134   +/-   ##
=======================================
  Coverage   99.11%   99.11%           
=======================================
  Files           7        7           
  Lines         453      453           
=======================================
  Hits          449      449           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e50b9da...18f1567. Read the comment docs.

TimothyXu commented 2 years ago

I think everything looks fine after changing parseInt to parseFloat when getting the price in the js file, just need to sort out the BDD tests then this is done

TimothyXu commented 2 years ago

I'm fixing the tests for you, you don't need to do anything hang on

Adora2401 commented 2 years ago

I'm fixing the tests for you, you don't need to do anything hang on

Thank you. I am not sure why the TimesoutException happens as all the messages in BDD test are matched.

TimothyXu commented 2 years ago

I'm fixing the tests for you, you don't need to do anything hang on

Thank you. I am not sure why the TimesoutException happens as all the messages in BDD test are matched.

I believe just typos. Waiting for the GitHub CI to pass before approving this PR