search

2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

UI not showing some error messages #138

Closed TimothyXu closed 2 years ago

TimothyXu commented 2 years ago

See https://nyudevopsspring2022-3.slack.com/archives/C033J6GUC6L/p1651569268516559

E.g. affects Get Item button, Remove button, Hold for Later button, Resume for Purchase button, and probably others too.

TimothyXu commented 2 years ago

Still not working after the PR per professor's suggestions; waiting for further advice

yjjw commented 2 years ago

May I know which part "still not working" ? I think the current version will ensure that the inputs typed in the item_id, user_id, price and quantity fields must be numbers, not string texts

TimothyXu commented 2 years ago

May I know which part "still not working" ? I think the current version will ensure that the inputs typed in the item_id, user_id, price and quantity fields must be numbers, not string texts

Oh interesting. I tried on Chrome and what you said is true and this should be fine. But on Safari both locally and at http://nyu-shopcart-service-sp2203-dev.us-south.cf.appdomain.cloud, we can still enter string texts. So actually you're probably right this should be fine, I asked the professor waiting for his confirmation. It seems like that's a Safari problem not our problem