Normally per Agile and scrum, no one can accept their own pull requests so we have at least 2 sets of eyes on a piece code before they are merged. However since you've done it already and I looked through the changes and they are fine, we'll continue on from here as if someone else approved the pull request. Also I understand this specific commit should be urgently merged as this is needed before any real development happens from others.
Per homework instructions, on Zenhub I have linked these 2 commits (that have already been merged) to the "set up dev env" story; I also moved that story BACK from Done to Review/Q&A, as that's what we need to do per Agile/scrum. At the end of this sprint when we do a Sprint Review, the Product Owner (for this sprint that person is me) will decide if the story can be moved from Review/Q&A to done, according to the Acceptance Criteria of the story.
Copying same comment from pull request #18 :
Normally per Agile and scrum, no one can accept their own pull requests so we have at least 2 sets of eyes on a piece code before they are merged. However since you've done it already and I looked through the changes and they are fine, we'll continue on from here as if someone else approved the pull request. Also I understand this specific commit should be urgently merged as this is needed before any real development happens from others.
Per homework instructions, on Zenhub I have linked these 2 commits (that have already been merged) to the "set up dev env" story; I also moved that story BACK from Done to Review/Q&A, as that's what we need to do per Agile/scrum. At the end of this sprint when we do a Sprint Review, the Product Owner (for this sprint that person is me) will decide if the story can be moved from Review/Q&A to done, according to the Acceptance Criteria of the story.