search

2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

Commented out code in routes.py, test_routes.py #28

Closed TimothyXu closed 2 years ago

TimothyXu commented 2 years ago

per Professor's instructions

kdokm commented 2 years ago

I think since you have reverted the previous merge, the code in main has already been without these added functions and tests. So, maybe we don't need another pull request to comment them out. I said these based on my understanding that according to what prof mentioned, actually the commit for 'starter code' is already the code for skeleton. If I'm wrong, please point it out, or maybe I should close this pull request. Although we revert the added functions and tests, they still help. We can reference it or reuse it if we want when completing other stories, so thank you very much for doing these before! Also, kindly remind that make sure you're using a new branch that is synced with main in your next work to avoid merge conflicts!

TimothyXu commented 2 years ago

Agreed kdokm (sorry I do not know if you are Yinuo or Yuwen haha). Yes I just basically commented out everything I wrote so we can reject this pull request, then if anyone wants reference they can look at the commit history. And thank you for pointing out about preventing merge conflicts! I'm trying hard to learn haha thank you.