search

2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

enable 'list shopcarts' and complete 'read shopcarts' #36

Closed kdokm closed 2 years ago

kdokm commented 2 years ago

Implemented the function of listing all shopcarts Ensured the right usage of 'create shopcarts' (not to mess with 'update shopcarts' when it comes to items, some work related to 'update shopcarts' so I haved requested review from TimothyXu) Completed some tests which cannot be done without implementation of 'read shopcarts'

kdokm commented 2 years ago

Maybe due to the previous revert or auto merge mistake, it seems like some codes for 'get shopcarts' disappear from main, and I bring it back now. I think actually revert is also very bad, although it happened because of mistakes.

TimothyXu commented 2 years ago

Agreed I hate to revert too, hopefully won't have to do it again. I'm reviewing now. Thanks for helping sort out the mistakes