search

2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

first working version of read an item in a certain shopcart #72

Closed Adora2401 closed 2 years ago

Adora2401 commented 2 years ago

Add read_an_item(shopcart_id, item_id) in routes.py Add test_read_an_item(self) and test_read_an_item_not_found(self) in test_routes.py

Adora2401 commented 2 years ago

Sorry for the first version. I found some of annotation not clear. I will quick check and commit again.

Adora2401 commented 2 years ago

Second version pushed.

Adora2401 commented 2 years ago

Third version solved the conflicts.

yjjw commented 2 years ago

Sorry, but shouldn't we get status code 404 when the requested shopcart id or the requested item id does not exist? Seems that the current version does not return 404

yjjw commented 2 years ago

Oh never mind, saw the test not found out there.