UI list shopcarts

[Adora2401]

This commits implements the UI of listing shopcarts. Now I left "No shopcarts in database" to indicate the press of button when there's no shopcart. Edit: pls see the code in latest version, changed the way of showing the result of listing all the shopcarts.

[codecov-commenter]

Codecov Report

Merging #95 (c46adcd) into main (5ecb68b) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files           7        7           
  Lines         380      380           
=======================================
  Hits          376      376           
  Misses          4        4           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ecb68b...c46adcd. Read the comment docs.

[kdokm]

I think you need to do bdd tests for this button also. Just copy the acceptance criteria to shopcarts.feature, change some content in it and web_steps.py to make names consistent etc.

[Adora2401]

Thanks Yuwen! I have re-read the story and changed the way of showing the result of listing shopcarts from a table into status message. And changed the shopcarts.feature according to acceptance criteria. But I am not sure whether we need add sth into web_steps.py as related code is here.

[kdokm]

Thanks Yuwen! I have re-read the story and changed the way of showing the result of listing shopcarts from a table into status message. And changed the shopcarts.feature according to acceptance criteria. But I am not sure whether we need add sth into web_steps.py as related code is here.

Sorry but I think maybe it's our story which need to be changed? Showing actual results in message seems strange to me... For web_steps.py, you need to modify the texts of shopcarts.feature or web_steps.py so that it can call the corresponding methods in web_steps.py from the texts of shopcarts.feature.

[Adora2401]

OK, I will use table to show the real result, change the story and so on. Do you think we should add a new table to show shopcart id seperately or just add a column in the search table? I am not sure which is better.

[kdokm]

OK, I will use table to show the real result, change the story and so on. Do you think we should add a new table to show shopcart id seperately or just add a column in the search table? I am not sure which is better.

I prefer a new table. However, I have posted this question in Slack. Maybe you can wait for a while to finalize it. If it is good, then I can modify the story and you just copy it again.

[Adora2401]

OK, I will use table to show the real result, change the story and so on. Do you think we should add a new table to show shopcart id seperately or just add a column in the search table? I am not sure which is better.

I prefer a new table. However, I have posted this question in Slack. Maybe you can wait for a while to finalize it. If it is good, then I can modify the story and you just copy it again.

Oh I see, in next sprint we will finish this function. Thanks Yuwen, I will keep this branch and wait the new meeting & stories.

[kdokm]

OK, I will use table to show the real result, change the story and so on. Do you think we should add a new table to show shopcart id seperately or just add a column in the search table? I am not sure which is better.

I prefer a new table. However, I have posted this question in Slack. Maybe you can wait for a while to finalize it. If it is good, then I can modify the story and you just copy it again.

Oh I see, in next sprint we will finish this function. Thanks Yuwen, I will keep this branch and wait the new meeting & stories.

Wait! We continue to finish stories in progress, just no more new stories. What I said is about how to show the results.

[TimothyXu]

Yes I was trying to reduce work when writing this story so I didn't want to mandate a new table so I thought of showing the results in status but you're right that's not a very good implementation. Since you've already done the work of creating a new table I definitely agree yes change the acceptance criteria to reflect this new table.

[Adora2401]

Now I think everything works well.

[TimothyXu]

Sorry my bad the behave isn't parsing correctly

[TimothyXu]

fixed in #97