search

2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

UI for get_shopcarts #97

Closed TimothyXu closed 2 years ago

kdokm commented 2 years ago

Just a minor thing, in line 75 of the feature file, there is an extra space in "ring1". Also, when we enter "1003" as the user id, if there is a better wording to describe that we get nothing in the results? I am not experienced on this part, just curious

That extra space is my typo in story, sorry for that. I fixed the text in the story just now. We might be able to see if some fields are empty, although maybe it is a little different to check fileds in table. I just think it is enough for the given data, if you want, I can try to figure out this.

yjjw commented 2 years ago

Just a minor thing, in line 75 of the feature file, there is an extra space in "ring1". Also, when we enter "1003" as the user id, if there is a better wording to describe that we get nothing in the results? I am not experienced on this part, just curious

That extra space is my typo in story, sorry for that. I fixed the text in the story just now. We might be able to see if some fields are empty, although maybe it is a little different to check fileds in table. I just think it is enough for the given data, if you want, I can try to figure out this.

That is fine, in the given scenario, I think the current testing should be good to go

TimothyXu commented 2 years ago

Fixed and ready for merge.