2022-Spring-NYU-DevOps-Shopcarts / shopcarts

Shopcarts squad.
Apache License 2.0
2 stars 2 forks source link

Create bdd.yml #99

Closed TimothyXu closed 2 years ago

TimothyXu commented 2 years ago

For CI with GitHub actions using Behave for BDD

codecov-commenter commented 2 years ago

Codecov Report

Merging #99 (4e45333) into main (906f0ca) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files           7        7           
  Lines         380      380           
=======================================
  Hits          376      376           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 906f0ca...4e45333. Read the comment docs.

kdokm commented 2 years ago

I think bdd.yml needs to be change because we do not use cloudDB but use PostgreSQL

TimothyXu commented 2 years ago

I don't know how to fix this 'chromedriver needs to be in PATH issue in the container' so will ask the Professor

kdokm commented 2 years ago

The newest error is because we didin't specify installing chrome-driver in our files.

TimothyXu commented 2 years ago

The newest error is because we didin't specify installing chrome-driver in our files.

I just updated requirements.txt but it's still not working

kdokm commented 2 years ago

The newest error is because we didin't specify installing chrome-driver in our files.

I just updated requirements.txt but it's still not working

Maybe there are version issues or something, we can ask professor.

kdokm commented 2 years ago

The newest error is because we didin't specify installing chrome-driver in our files.

I just updated requirements.txt but it's still not working

I checked the latest error and I think maybe we should double check if the service runs for the correct port when action is doing bdd checks.

TimothyXu commented 2 years ago

The newest error is because we didin't specify installing chrome-driver in our files.

I just updated requirements.txt but it's still not working

I checked the latest error and I think maybe we should double check if the service runs for the correct port when action is doing bdd checks.

You're right I'm trying to check

TimothyXu commented 2 years ago

I'm out of ideas. Either someone else can take a look or maybe the Professor will reply on #homework

kdokm commented 2 years ago

I'm out of ideas. Either someone else can take a look or maybe the Professor will reply on #homework

I have fixed the problem in #102. You can either close my pull request and make changes in your branch, or directly use my pull request.