Error when compiling generated code

[florian-richter]

Describe the bug Hi, I am trying to generate a client for a service that uses inheritance (has entities with a BaseType). The client generates typescript files but they won't compile as the inheriting entities don't have key properties.

To Reproduce Use this MWE.

service-specs/service-mapping.json:

{
  "test": {
    "directoryName": "test",
    "servicePath": "/test",
    "npmPackageName": "test"
  }
}

service-specs/test.edmx:

<?xml version='1.0' encoding='UTF-8'?>
<edmx:Edmx 
  xmlns:edmx="http://schemas.microsoft.com/ado/2007/06/edmx" Version="1.0">
  <edmx:DataServices m:DataServiceVersion="1.0" 
    xmlns:m="http://schemas.microsoft.com/ado/2007/08/dataservices/metadata">
    <Schema Namespace="ns" 
      xmlns="http://schemas.microsoft.com/ado/2008/09/edm">
      <EntityType Name="MyBaseType">
        <Key>
          <PropertyRef Name="id"/>
        </Key>
        <Property Name="id" Type="Edm.String" Nullable="false"/>
      </EntityType>
      <EntityType Name="MyType" BaseType="ns.MyBaseType">
        <Property Name="name" Type="Edm.String" Nullable="true"/>
      </EntityType>
      <EntityContainer Name="DefaultContainer" m:IsDefaultEntityContainer="true">
        <EntitySet Name="MyType" EntityType="ns.MyType"/>
      </EntityContainer>
    </Schema>
  </edmx:DataServices>
</edmx:Edmx>

• Entity MyType inherits from MyBaseType
• MyBaseType has the key
• MyType only adds one non-key property

package.json:

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "generate-client": "generate-odata-client -i service-specs -o generated --forceOverwrite --clearOutputDir"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
    "@sap-cloud-sdk/connectivity": "^2.6.0",
    "@sap-cloud-sdk/odata-common": "^2.6.0",
    "@sap-cloud-sdk/odata-v2": "^2.6.0",
    "@sap-cloud-sdk/util": "^2.6.0"
  },
  "devDependencies": {
    "@sap-cloud-sdk/generator": "^2.6.0"
  }
}

Steps to reproduce the behavior:

1. Create files above
2. Run command npm run generate-client
3. Notice that service generation fails

Expected behavior The cloud SDK should generate valid typescript code. In this case it should respect entity inheritance and merge all properties and especially the key.

Used Versions:

• node version via node -v: 14.15.1
• npm version via npm -v: 8.11.0
• SAP Cloud SDK version you used as dependency: 2.6.0

Impact / Priority

This is for an internal project only. There is no deadline. I will try to adjust the metadata so that there is no inheritance.

Additional context Instead of using the MWE above, you can also use SAP's IntegrationContent service at https://api.sap.com/api/IntegrationContent/overview. This is the service that I wasn't able to use because of the bug.

[florian-richter]

!similar

[bot-sdk-js]

These are the most similar issues to "Error when compiling generated code":

• 🥇 #1207 (Similarity: 93.6%)
• 🥈 #1726 (Similarity: 91.0%)
• 🥉 #682 (Similarity: 90.9%)

🤖 💬 I hope this was helpful. BEEP BOOP.